You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Created some base classes that i think could be the bassis of the package.
BaseFileHandler is the base class for all files and contains most of the logic for reading and writing of the file. The BaseFileHandler has an data attribute that contains a CompositeData instance where all the logic of the data is handled. The CompositeData can be inherited from the define the data structure of a certain file. The fields of a file can then be defined with the help of the DataComponent. What do you guys think?
I just nottice i didn't put a lot of documentation inside the code but I will do it in the next commit.
Hey Simon,
Great job on the PR.
I like the implementation with (nested) ABC classes, I think it gives a lot of flexibility for different data types.
One thing that is not immediately clear for me with this implementation is how this implementation would "enforce" a standard way to store for example distance or speed data. For example, how would BaseFileHandler.to_df() always parse speed data in the same way? Or is the point that the implementation doesn't enforce that?
Hi Aert
This question kept me also awake for a couple of nights... But I think that the best way is that we create a class inhertited from the DataComponent called RecordData (maybe we should think about a more brother term like ActivityData or somthing) where we define how the data should look and thus also how we should parse the the data. The second options is that we even go further and create for every type of data (speed, power, etc...) a seprate component (and not store the entire ActivityData as a component it self ). so that the parse funciton is implemented in for example a SpeedData component but i don't know if this is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress...
Created some base classes that i think could be the bassis of the package.
BaseFileHandleris the base class for all files and contains most of the logic for reading and writing of the file. TheBaseFileHandlerhas andataattribute that contains aCompositeDatainstance where all the logic of the data is handled. TheCompositeDatacan be inherited from the define the data structure of a certain file. The fields of a file can then be defined with the help of theDataComponent. What do you guys think?I just nottice i didn't put a lot of documentation inside the code but I will do it in the next commit.